Create the 'out' directory before restoring packages

alanmcgovern · alanmcgovern · commit 43108eda7850 · 2024-07-17T13:41:01.000+01:00
This makes it easier to guarantee the path always exists so msbuild
/t:Restore more reliably succeeds.

Don't rely on running the 'pack' command to create the directory.
diff --git a/build.proj b/build.proj
@@ -5,6 +5,7 @@
         <CI Condition="'$(CI)' == '' ">false</CI>
 
         <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+        <!-- this is also in src/Directory.Build.props -->
         <Out Condition=" '$(Out)' == '' ">$(MSBuildThisFileDirectory)out</Out>
 
         <MSBuildCommonProperties>$(MSBuildCommonProperties);Deterministic=true</MSBuildCommonProperties>
@@ -39,7 +40,6 @@
     </Target>
 
     <Target Name="Pack">
-        <MakeDir Directories="$(Out)" />
         <MSBuild
             Projects="@(PackFile)"
             Properties="$(MSBuildCommonProperties);Configuration=%(PackFile.Configuration);PackageOutputPath=$(Out)"
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -46,7 +46,9 @@
     <Deterministic>true</Deterministic>
     <RestorePackagesWithLockFile>false</RestorePackagesWithLockFile>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    
+
+    <Out Condition=" '$(Out)' == ''">$(MSBuildThisFileDirectory)..\out</Out>
+
     <!-- These are essentially junk if i'm compiling against net472/NetStandard2.0 and newer targets.
          Most rules result in uncompilable net472 code, so let's ignore them as i don't want to wade
          through fixing/ignoring hundreds of rules with little real-world value. -->
diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets
@@ -42,6 +42,10 @@
     <PackageReference Update="System.Memory" Version="$(SystemMemoryVersion)" />
   </ItemGroup>
 
+  <Target Name="CreateOutDirectory" BeforeTargets="_GetAllRestoreProjectPathItems;Restore;BeforeResolveReferences;CollectPackageReferences">
+    <MakeDir Directories="$(Out)" />
+  </Target>
+
   <Target Name="SetAssemblyVersion" BeforeTargets="GetAssemblyVersion" Condition="'$(RestoreSuccess)' != 'true' Or '$(Configuration)' == 'Debug' Or '$(GitInfoVersion)' == '' ">
     <PropertyGroup>
       <Version>0.0.0.1</Version>
