Repository navigation
Preserve feed URL ampersands and restore WordPress trunk CI - #742
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feed URLs containing query parameters such as
¶meters=thatare decoded as HTML character references by WordPress trunk's GUID filters, corrupting the stored URL and causing repeated imports to create duplicate posts. Escape the permalink before passing it through those filters, and extend the ampersand regression test to check both the remote-post map and the direct URL lookup.Restore the CI matrix by ignoring only dependency PHP upper bounds, preserving minimum PHP and extension requirements so Composer cannot install an incompatible PHPUnit dependency. Update ActivityPub assertions to verify image attributes and mention content independently of HTML attribute order.
Validation:
includes/class-feed.php, PHP syntax checks for the modified tests, andgit diff --check.Changelog
Type
Message
Preserve ampersands in imported feed URLs to prevent corrupted links and duplicate posts on newer WordPress versions.
Test this PR in WordPress Playground
You can test this pull request directly in WordPress Playground:
Launch WordPress Playground
This will install and activate the plugin with the changes from this PR.