Repository navigation
Notify Mastodon apps about received messages - #711
Merged
Merged
Conversation
Messages received from a friend showed up in the conversations of a Mastodon app, but never produced a notification, so there was no way of knowing that one had arrived without navigating to the conversations. Register the messages as a notification source through the new mastodon_api_get_notifications_queries filter. It is queried separately from the cached posts, whose query needs a tax_query for the mention tag that the messages don't carry. Refs akirk/enable-mastodon-apps#320 Claude-Session: https://claude.ai/code/session_01CUVxR8uyLTg2roNVWgp91y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes akirk/enable-mastodon-apps#320
A direct message received through a Mastodon app produces no notification, so the only way to notice one is to open the conversations view.
Changes
mastodon_api_get_notifications_queriesfilter added in Query every notification source separately enable-mastodon-apps#331, which queries each source on its own. That separation matters here: the query this integration already contributes for cached posts carries atax_queryfor the current user's mention tag, and messages don't carry that tag.Testing instructions
Changelog entry
Changelog Entry Details
Type
Message
Notify Mastodon apps about received direct messages.
https://claude.ai/code/session_01CUVxR8uyLTg2roNVWgp91y
Test this PR in WordPress Playground
You can test this pull request directly in WordPress Playground:
Launch WordPress Playground
This will install and activate the plugin with the changes from this PR.