lib/plugins/Label_16_POSA1.ts (1)

23-32: Consider adding input validation for empty or malformed messages.

The validation checks for the number of fields and preamble, but it might be worth adding checks for:

• Empty message text
• Malformed field values

 decode(message: Message, options: Options = {}) : DecodeResult {
   const decodeResult = this.defaultResult();
   decodeResult.decoder.name = this.name;
   decodeResult.formatted.description = 'Position Report';
   decodeResult.message = message;

+  if (!message.text?.trim()) {
+    if (options.debug) {
+      console.log('Decoder: Empty message text');
+    }
+    decodeResult.remaining.text = message.text || '';
+    decodeResult.decoded = false;
+    decodeResult.decoder.decodeLevel = 'none';
+    return decodeResult;
+  }

   const fields = message.text.split(',');

lib/plugins/Label_16_TOD.ts (1)

22-32: Consider adding input validation for empty or malformed messages.

Similar to the POSA1 decoder, consider adding validation for:

• Empty message text
• Malformed field values

 decode(message: Message, options: Options = {}) : DecodeResult {
   const decodeResult = this.defaultResult();
   decodeResult.decoder.name = this.name;
   decodeResult.formatted.description = 'Position Report';
   decodeResult.message = message;

+  if (!message.text?.trim()) {
+    if (options.debug) {
+      console.log('Decoder: Empty message text');
+    }
+    decodeResult.remaining.text = message.text || '';
+    decodeResult.decoded = false;
+    decodeResult.decoder.decodeLevel = 'none';
+    return decodeResult;
+  }

   const fields = message.text.split(',');

lib/plugins/Label_16_POSA1.test.ts (1)

22-39: Consider adding edge case tests.

While the current tests cover valid and redacted cases well, consider adding tests for:

• Empty message text
• Malformed coordinates
• Invalid numeric values
• Missing fields

test('handles empty message', () => {
  const text = '';
  const decodeResult = plugin.decode({ text });
  expect(decodeResult.decoded).toBe(false);
  expect(decodeResult.decoder.decodeLevel).toBe('none');
});

test('handles malformed coordinates', () => {
  const text = 'POSA1INVALID,GEARS,221626,370,BBOBO,222053,,-61,139,1174,829';
  const decodeResult = plugin.decode({ text });
  expect(decodeResult.decoded).toBe(false);
  expect(decodeResult.decoder.decodeLevel).toBe('none');
});

Also applies to: 41-58

lib/plugins/Label_16_TOD.test.ts (3)

26-26: Remove debug console.log statement.

The console.log statement should be removed as it's not needed for testing and could clutter test output.

-    console.log(decodeResult.formatted.items);

---

22-43: Add test case for remaining text validation.

The test verifies the decoding of variant 1 but doesn't validate the content of remaining.text. While line 42 checks that it equals ' 97', there's no explanation of what this value represents or why it's important.

Consider adding a comment explaining the significance of the remaining text:

+    // Verify remaining text contains the ground speed value
     expect(decodeResult.remaining.text).toBe('  97');

---

45-67: Enhance test coverage with edge cases.

The test suite covers basic scenarios but could benefit from additional edge cases:

1. Messages with invalid timestamps
2. Messages with out-of-range altitudes
3. Messages with malformed coordinates

Would you like me to generate additional test cases for these scenarios?

Also applies to: 70-86, 88-97

lib/MessageDecoder.ts (1)

11-75: Consider refactoring plugin registration.

The constructor contains a long list of plugin registrations which could be better organized. Consider grouping plugins by label or functionality and moving the registration logic to a separate method.

Example refactor:

private registerDefaultPlugins(): void {
  const pluginGroups = {
    label10: [
      new Plugins.Label_10_LDR(this),
      new Plugins.Label_10_POS(this),
      new Plugins.Label_10_Slash(this),
    ],
    label16: [
      new Plugins.Label_16_N_Space(this),
      new Plugins.Label_16_POSA1(this),
      new Plugins.Label_16_TOD(this),
    ],
    // ... other groups
  };

  Object.values(pluginGroups).flat().forEach(plugin => this.registerPlugin(plugin));
}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

lib/plugins/Label_16_TOD.test.ts (4)

22-41: Add assertions for remaining text format.

While the test case is comprehensive in validating the decoded fields, consider adding assertions to verify the format of the remaining text (e.g., length, numeric content).

     expect(decodeResult.formatted.items[3].value).toBe('38.364 N, 75.226 W');
     expect(decodeResult.remaining.text).toBe('  97');
+    expect(decodeResult.remaining.text.trim()).toMatch(/^\d+$/);

---

43-65: Add assertions for remaining text format.

Similar to variant 1, consider adding assertions to verify the format of the remaining text. Additionally, the test case effectively uses a real-world example, which is good practice.

     expect(decodeResult.formatted.items[4].value).toBe('SXS7SL');
     expect(decodeResult.remaining.text).toBe(' 51');
+    expect(decodeResult.remaining.text.trim()).toMatch(/^\d+$/);

---

68-84: Add assertions for remaining text format.

Similar to previous variants, consider adding assertions to verify the format of the remaining text. The test case effectively handles missing position data.

     expect(decodeResult.formatted.items[1].value).toBe('12:06:00');
     expect(decodeResult.remaining.text).toBe(' 92');
+    expect(decodeResult.remaining.text.trim()).toMatch(/^\d+$/);

---

86-95: Add assertion for empty formatted items.

For invalid messages, verify that no formatted items are present to ensure complete validation of the error case.

     expect(decodeResult.decoder.name).toBe('label-16-tod');
     expect(decodeResult.formatted.description).toBe('Position Report');
     expect(decodeResult.message.text).toBe(text);
+    expect(decodeResult.formatted.items.length).toBe(0);

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

lib/plugins/Label_4A.ts (1)

41-44: Consider refactoring altitude handling for consistency.

The current implementation has several areas for improvement:

1. Using hardcoded positions (48, 51) is brittle and differs from the field-based approach used elsewhere
2. Altitude handling is inconsistent across variants (compare with lines 55 and 69)

Consider refactoring to use the fields array and standardizing altitude handling across all variants:

-        const alt = text.substring(48, 51);
-        if(alt !== '') {
-            ResultFormatter.altitude(decodeResult, Number(alt) * 100);
-        }
+        const alt = fields[6]; // Adjust index based on your field structure
+        if (alt && alt.trim() !== '') {
+            ResultFormatter.altitude(decodeResult, Number(alt) * 100);
+        }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro