fix: update source-declarative-manifest entrypoint#84
Merged
aaronsteers merged 3 commits intomainfrom Nov 22, 2024
Merged
Conversation
Contributor
📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request focus on the Dockerfile, specifically updating the entrypoint configuration. The previous entrypoint command using Poetry has been simplified to directly invoke Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Wdyt about these suggestions? Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
aaronsteers
approved these changes
Nov 22, 2024
aaronsteers
temporarily deployed
to
DockerHub
GitHub Actions
Inactive
This was referenced Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #83
The platform's orchestrator has specific requirements about how it executes connector containers. Our entrypoint using
poetry runwas causing failures in both Cloud and OSS environments. This change aligns our container configuration with platform expectations.Changes
poetry runfrom the entrypoint commandAIRBYTE_ENTRYPOINTenvironment variable required by the platformHow to test
Summary by CodeRabbit
AIRBYTE_ENTRYPOINTto streamline the entrypoint command.source-declarative-manifest.