Christo/finalize cdk sdm publish flow #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsteers
reviewed
Nov 19, 2024
aaronsteers
reviewed
Nov 19, 2024
Comment on lines
53
to
60
| - name: Attach Wheel to GitHub Release | ||
| uses: svenstaro/upload-release-action@v2 | ||
| with: | ||
| repo_token: ${{ secrets.GITHUB_TOKEN }} | ||
| file: dist/*.whl | ||
| tag: ${{ github.ref }} | ||
| tag: ${{ env.VERSION }} | ||
| overwrite: true | ||
| file_glob: true |
Contributor
There was a problem hiding this comment.
@ChristoGrab - This step will only work with release tag events.
You can add an "if" condition like if: startsWith(github.ref, 'refs/tags/v') to skip it for workflow dispatch.
The reason is that it's job is to attach the wheel to the release (not strictly necessary anyway). If using the VERSION env var, the "tag" format will probably need to be reconstructed: refs/tags/v${VERSION}.
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…om/airbytehq/airbyte-python-cdk into christo/finalize-cdk-sdm-publish-flow
…b.com/airbytehq/airbyte-python-cdk into christo/finalize-cdk-sdm-publish-flow
Collaborator
Author
|
Closing in favour of a fresh PR here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAT WAT