fix: unmark partition router as linkable#683
Conversation
lmossman
changed the title
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@lmossman/make-partition-router-not-linkable#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch lmossman/make-partition-router-not-linkableHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the linkable: true property from the partition_router definition in the declarative component schema to prevent funky edge cases during manifest normalization when partition routers use $refs.
- Removes the
linkable: trueproperty from the partition_router schema definition - Addresses normalization issues in the CDK when partition routers contain
$refs pointing to different streams
📝 WalkthroughWalkthroughThis change removes the "linkable: true" attribute from the "partition_router" property within the "SimpleRetriever" schema definition in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Would you like to cross-reference these related PRs in your summary or changelog for extra context, wdyt? Suggested labels
Would you like to add any additional labels, or does Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
2 participants
This PR makes
partition_routerno longer linkable.Since the Builder uses
$refs in partition_router to point to different streams, there were some funky edge cases happening when the CDK would normalize manifests that contained partition routers.I don't actually think there is that much value in having partition_routers be linkable across streams anyway, because they tend to be pretty stream-specific. So the safest and easiest change is to just stop linking them.
Summary by CodeRabbit