Skip to content

chore: use python base image 4.0.0 in SDM#382

Merged
natikgadzhi merged 2 commits intomainfrom
ng/python-3.11-base-image
Mar 4, 2025
Merged

chore: use python base image 4.0.0 in SDM#382
natikgadzhi merged 2 commits intomainfrom
ng/python-3.11-base-image

Conversation

@natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented Mar 4, 2025 •
edited by coderabbitai bot
Loading

This would push all manifest sources that use the CDK to run on Python 3.11.

So far, we have 60+ sources on Python 3.11 base image and things are smooth.

Summary by CodeRabbit

  • Chores
    • Upgraded the container base image to version 4.0.0 for improved support and performance.
    • Updated the Python version from 3.10 to 3.11 in the build process.

@github-actions github-actions bot added the chore label Mar 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

This PR updates the Dockerfile to use a newer version of the base image for the Python connector. The update changes the image from airbyte/python-connector-base:3.0.0 (with its associated digest) to airbyte/python-connector-base:4.0.0 with a new digest. Additionally, the Python version referenced in file paths is updated from python3.10 to python3.11. These adjustments ensure that the Docker container will now build using the updated base image and Python environment.

Changes

File Summary
Dockerfile Updated base image from airbyte/python-connector-base:3.0.0 with digest sha256:1a0845...d34d844 to airbyte/python-connector-base:4.0.0 with digest sha256:d9894...7bbe22. Updated file copy paths to reference python3.11 instead of python3.10.

Possibly related PRs

Suggested reviewers

  • Would you consider adding aaronsteers as a reviewer, wdyt?
  • How about getting ChristoGrab's input on this change, wdyt?
  • Would you like to include alafanechere in the review process, wdyt?
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46a4206 and 30e0e44.

📒 Files selected for processing (1)
  • Dockerfile (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (python)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Dockerfile (1)

8-8: Base image update looks good!
The update to use airbyte/python-connector-base:4.0.0 with the new digest is consistent with our PR objectives to standardize on Python 3.11. One quick question: since the new base image targets Python 3.11, do we also need to update the version-specific paths later in the Dockerfile (for instance, line 27 still references /usr/local/lib/python3.10/)? wdyt?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between caa24a0 and 46a4206.

📒 Files selected for processing (1)
  • Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Analyze (python)

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented Mar 4, 2025

Hold up, this no worky worky

 => ERROR [7/9] RUN mkdir -p source_declarative_manifest     && echo 'from source_declarative_manifest.run import run\n  0.1s
------
 > [7/9] RUN mkdir -p source_declarative_manifest     && echo 'from source_declarative_manifest.run import run\n\nif __name__ == "__main__":\n    run()' > main.py     && touch source_declarative_manifest/__init__.py     && cp /usr/local/lib/python3.10/site-packages/airbyte_cdk/cli/source_declarative_manifest/_run.py source_declarative_manifest/run.py     && cp /usr/local/lib/python3.10/site-packages/airbyte_cdk/cli/source_declarative_manifest/spec.json source_declarative_manifest/:                  0.107 cp: cannot stat '/usr/local/lib/python3.10/site-packages/airbyte_cdk/cli/source_declarative_manifest/_run.py': No such file or directory
------
Dockerfile:24
--------------------
  23 |     # Recreate the original structure
  24 | >>> RUN mkdir -p source_declarative_manifest \
  25 | >>>     && echo 'from source_declarative_manifest.run import run\n\nif __name__ == "__main__":\n    run()' > main.py \
  26 | >>>     && touch source_declarative_manifest/__init__.py \
  27 | >>>     && cp /usr/local/lib/python3.10/site-packages/airbyte_cdk/cli/source_declarative_manifest/_run.py source_declarative_manifest/run.py \
  28 | >>>     && cp /usr/local/lib/python3.10/site-packages/airbyte_cdk/cli/source_declarative_manifest/spec.json source_declarative_manifest/
  29 |
--------------------
ERROR: failed to solve: process "/bin/sh -c mkdir -p source_declarative_manifest     && echo 'from source_declarative_manifest.run import run\\n\\nif __name__ == \"__main__\":\\n    run()' > main.py     && touch source_declarative_manifest/__init__.py     && cp /usr/local/lib/python3.10/site-packages/airbyte_cdk/cli/source_declarative_manifest/_run.py source_declarative_manifest/run.py     && cp /usr/local/lib/python3.10/site-packages/airbyte_cdk/cli/source_declarative_manifest/spec.json source_declarative_manifest/" did not complete successfully: exit code: 1

View build details: docker-desktop://dashboard/build/orbstack/orbstack/wkrrurvbeq385p59oxwn7bgg9

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented Mar 4, 2025

I fixed it for now, but we need a better solution for potentially broken dockerfiles

@natikgadzhi natikgadzhi merged commit 169a08c into main Mar 4, 2025
20 checks passed
@natikgadzhi natikgadzhi deleted the ng/python-3.11-base-image branch March 4, 2025 21:35
@coderabbitai coderabbitai bot mentioned this pull request Jul 11, 2025
Merged
This was referenced Oct 20, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@natikgadzhi