This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Open
Conversation
This was referenced May 10, 2018
ljharb
previously requested changes
May 10, 2018
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I think this is the right way to do it, but we should change index.js so that it pulls in client and server (so there's only one source of truth)
Author
|
@ljharb good that the concept is the right way to go, worked it out a little more please review. |
ljharb
reviewed
May 11, 2018
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
LGTM but i'll let others review/merge
| }, | ||
| server: () => renderReactStaticServer(name, component), | ||
|
|
||
| client() {}, |
Collaborator
There was a problem hiding this comment.
nit: client() {} is preferred over client: () => {}
Author
There was a problem hiding this comment.
thanks for noticing, arrow function is indeed not necessary in object methods
wingleung
force-pushed
the
separate-client-and-server-logic
branch
2 times, most recently
from
53149e7 to
aad6a8a
Compare
wingleung
force-pushed
the
separate-client-and-server-logic
branch
from
b645d05 to
e8fb23f
Compare
Author
|
@ljharb @goatslacker ready to review, this PR splits server and client code making client code smaller |
ljharb
force-pushed
the
separate-client-and-server-logic
branch
from
e8fb23f to
681dbf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting #5 started...
existing endpoint left intact to not break current implementations, or should we break?
new import on server side apps
import { renderReact } from 'hypernova-react/server';new import client side
import { renderReact } from 'hypernova-react/client';