Skip to content

Fix gradient descent for LinearLearning #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norvig merged 1 commit into from
Mar 25, 2017
Merged

Fix gradient descent for LinearLearning #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion learning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,7 @@ def LinearLearner(dataset, learning_rate=0.01, epochs=100):
idx_i = dataset.inputs
idx_t = dataset.target # As of now, dataset.target gives only one index.
examples = dataset.examples
num_examples = len(examples)

# X transpose
X_col = [dataset.values[i] for i in idx_i] # vertical columns of X
Expand All @@ -657,7 +658,8 @@ def LinearLearner(dataset, learning_rate=0.01, epochs=100):

# update weights
for i in range(len(w)):
w[i] = w[i] - learning_rate * dotproduct(err, X_col[i])
w[i] = w[i] + learning_rate * (dotproduct(err, X_col[i]) / num_examples)


def predict(example):
x = [1] + example
Expand Down