Add GitHub Flavored Markdown mode, Add some more Markdown fileExtensions #9780
Conversation
Note you can only ever get into GFM mode using the Language Switcher. fileExtensions source: https://github.com/github/markup#markups
|
Looks good to me. |
|
Comment to test gfm comment (edit comment to see) |
|
@redmunds An interesting part about your comment is that it displays the hidden portion in the email sent: |
|
@Mark-Simulacrum inline comments don't seem to work -- only block-level comments. |
src/language/languages.json
Outdated
There was a problem hiding this comment.
Shouldn't there be at least 1 file extension?
There was a problem hiding this comment.
Since GitHub Flavored Markdown is a subset of markdown, I'm not sure if we can/should list any extensions: if we do, they would have to be the same as the (regular) markdown extensions, but that could create conflicts inside Brackets. I'm not sure, but perhaps just leaving it to the user to switch to GitHub Flavored Markdown mode is the best option.
There was a problem hiding this comment.
AFAIK GFM has the exact same file extensions Markdown has, and I'm not sure what happens if two modes use the same file extensions.
You can still use GFM using the Language Switcher, where you can define it as default mode as well.
|
Done with code review. |
|
Code review comments adressed. |
|
Right, you can't have two languages with the same set of extensions. One will just overwrite the other. So as I said above, I don't think this is ideal in terms of discoverability... but I think it's fair to merge it since it's still better than nothing. |
|
Merging. |
Add GitHub Flavored Markdown mode, Add some more Markdown fileExtensions
5 participants
Note you can only ever get into GFM mode using the Language Switcher.
Also added some more
fileExtensionsfor Markdown. Source: https://github.com/github/markup#markups