Skip to content

Add logo support for commands#112

Closed
kodie wants to merge 53 commits intoadhocore:mainfrom
kodie:kodie/add-command-logo-support
Closed

Add logo support for commands#112
kodie wants to merge 53 commits intoadhocore:mainfrom
kodie:kodie/add-command-logo-support

Conversation

@kodie
Copy link
Contributor

@kodie kodie commented Nov 25, 2024 •
edited
Loading

Just like Application's logo function, Commands can have them now as well in the exact same way.

$app = new \Ahc\Cli\Application('Test App', '0.0.1');
$app->command('cmd')->logo('My ASCII Art');

Fixes #115

adhocore
adhocore reviewed Nov 26, 2024
View reviewed changes
adhocore
adhocore reviewed Nov 26, 2024
View reviewed changes
@adhocore
Copy link
Owner

adhocore commented Nov 26, 2024

thanks for the pull. should we also create corresponding issues for all the pulls?

@kodie kodie mentioned this pull request Nov 26, 2024
Closed
adhocore
adhocore reviewed Nov 26, 2024
View reviewed changes
adhocore
adhocore previously approved these changes Nov 26, 2024
View reviewed changes
@dimtrovich
Copy link
Contributor

dimtrovich commented Nov 26, 2024

is it necessary to define the logo when executing a command? personally, I think the current implementation is sufficient. leaving the logo when calling the default command seems more normal to me.

@kodie
Copy link
Contributor Author

kodie commented Nov 26, 2024 •
edited
Loading

is it necessary to define the logo when executing a command? personally, I think the current implementation is sufficient. leaving the logo when calling the default command seems more normal to me.

@dimtrovich As I mention in #115, currently, the logo doesn't show up for default commands, only for the built-in __default__ function. So if you set a logo and then use a default command, your logo would not be displayed. Also I like the freedom of being able to use a logo (possibly even unique logo) in any of the help screens (like maybe a different version of the ASCII art in each command if I so wished).

For example the logo showing in the screenshots I posted in #110 would not be possible without this PR as that is my default command I'm running help on.

@adhocore
Copy link
Owner

adhocore commented Nov 26, 2024

yea not super necessary but ok to have i guess as long as it doesn't mess up current working behavior or get on the way

btw pull needs rebase again :D

kodie added 16 commits November 26, 2024 09:51
@kodie
Make all written text built-in styles so that their styles can be cus…
79e459a 
…tomized
@kodie
Put back Interactor Writer method definitions
ef091d0
@kodie
Put back eol and table method definitions for Interactor
7f7466f
@kodie
Put this blank line back? I'm not sure how that happened
a4ebc07
@kodie
Remove un-needed space
229d58c
@kodie
Hopefully fix issue with test
5f7fb39
@kodie
Put factory color functions back
4463acb
@kodie
Prevent users from making factory functions invisible
1365912
@kodie
Shorten a couple lines
44c1bc1
@kodie
Update invisible_built_in_style expected exception message
0453b1b
@kodie
Add new method definitions for Writer and Interactor classes
5c2681e
@kodie
Make logo a built-in style
929aa8c
@kodie
Make help_description into help_description_even/odd and make help_it…
5017764 
…em into help_item_even/odd
@kodie
Fix indentation
47ef57b
@kodie
Add support for custom help screens
07a58fa
@kodie
Fix identation
7737fe6
kodie added 23 commits November 26, 2024 09:52
@kodie
Add Color::bg256 and Color::fg256
0a5c8ad
@kodie
Add periods to bg256 and fg256 descriptions
0bceee7
@kodie
Add mising A to fg256 example in readme
8bd27e1
@kodie
Add return types for bg256 and fg256 functions
cbb5476
@kodie
Make bg256 and fg256 functions static
50bfd67
@kodie
Use PHP comments in Default command example in readme instead of Bash…
a5358f4 
… comments
@kodie
Make all written text built-in styles so that their styles can be cus…
0d62301 
…tomized
@kodie
Put back eol and table method definitions for Interactor
b53faa7
@kodie
Put this blank line back? I'm not sure how that happened
00a7636
@kodie
Remove un-needed space
765b71d
@kodie
Hopefully fix issue with test
00cefbd
@kodie
Prevent users from making factory functions invisible
df68b6c
@kodie
Shorten a couple lines
641f690
@kodie
Add new method definitions for Writer and Interactor classes
d02e462
@kodie
Make help_description into help_description_even/odd and make help_it…
559a457 
…em into help_item_even/odd
@kodie
Add support for custom help screens
e051346
@kodie
Fix identation
f6fe5bc
@kodie
Add example to readme showing how you can get colors working in a cus…
7988eb7 
…tom help screen
@kodie
Add logo support for commands
a64b36c
@kodie
Make logo property logo for command to avoid any conflicts
7452e46
@kodie
Fix logo checking and writing
602d975
@kodie
Remove duplicate test_custom_help that happened during rebase somehow
757349f
@kodie
Return this from command logo function - got changed during rebase so…
cbec8dc 
…mwhow
@adhocore
Copy link
Owner

adhocore commented Nov 26, 2024

@kodie i think instead of fixing this conflict branch, it is easier to branch off new from the latest main and cherry-pick or hand-pick changes on top

@kodie
Copy link
Contributor Author

kodie commented Nov 26, 2024

@adhocore I'll do that now and submit a new PR.

@kodie kodie closed this Nov 26, 2024
@kodie kodie deleted the kodie/add-command-logo-support branch November 26, 2024 16:28
@kodie kodie mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adhocore adhocore adhocore left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logo command doesn't work if a custom default command is set

3 participants

@kodie @adhocore @dimtrovich