synthio: improvements based on feedback - #8024
Merged
Merged
Conversation
todbot discovered that this function wasn't working right, and wasn't well-named.
.. since math blocks can be placed in it too (and that's useful)
jepler
marked this pull request as ready for review
May 24, 2023 01:41
gamblor21
approved these changes
May 24, 2023
gamblor21
left a comment
gamblor21
left a comment
Member
There was a problem hiding this comment.
Tested on a Metro M7. blocks and voct_to_hz changes work. Documentation changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @todbot!
Synthesizer.blocksreplacesSynthesizer.lfos; the functionality is unchangedvoct_to_hzadded, replacesonveo_to_hz(which was totally incorrect in its implementation).filterin the Synthesizer constructorNote.frequencyasfloat.