Robo HAT MM1 updates v1.8 board - #2014
Merged
Merged
Conversation
Author
|
Hi there! I just made a few small changes to pins.c. These should not conflict with existing boards. Please let me know when this is likely to be merged in 😄 Thanks! |
tannewt
requested changes
Jul 29, 2019
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
We should be able to get this in shortly! Just one comment about the linker script. Thanks!
Author
|
@tannewt requesting review please 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit:
Should not impact on other boards AFAIK.