Fix infinite loop on STM32F103 #191
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to read temperature from a DHT11 when the sensor was disconnected, the program would encounter an infinite loop in DHT::expectPulse, because count would keep overflowing.
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to read temperature from a DHT11 with the sensor disconnected, the program would encounter an infinite loop in
DHT::expectPulse, becausecountwould keep overflowing.This PR changes the preprocessor
#ifexpression so that ifF_CPU == 0Lis true (which it is in my case withSTM32F103C8. I thinkF_CPUcontains the name of a variable), 32 bits is allocated forcountinstead of the insufficient 16 bits.This could potentially break platforms where
F_CPUis also evaluated to 0 by the preprocessor, but working with anuint32_tmakes the code run too slow. A less intrusive fix would be to add|| defined(ARDUINO_BLUEPILL_F103C8)instead. However, that would not fix the problem for other platforms like STM32F401, where it is also present.