Add missing microsecondsToClockCycles for 33 BLE #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Sep 8, 2020
Member
|
hi can merge if/when it passes CI! |
Member
|
please run |
Member
|
yay thanks! |
Contributor
Author
|
Thanks, happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Arduino Nano 33 BLE (and 33 BLE Sense) boards are based on mbed OS. Currently Arduino has not included the microsecondsToClockCycles() function in Arduino.h (or standard include files). There is some debate as to whether
or not the function belongs in the standard Arduino.h for this board. (See issue 101 here here).
This change adds the missing definition of microsecondsToClockCycles() to DHT.h only for the Nano 33 BLE Board only and only if it's not eventually included in the standard include.
There are no known limitations.
Testing has been verified on Arduino Uno, Arduino 33 IoT, and Arduino 33 BLE Sense boards with a DHT11 sensor.