code review for gorhill#404

gorhill · gorhill · commit 8f51ee2b90a9 · 2014-09-15T09:45:24.000-04:00
diff --git a/js/traffic.js b/js/traffic.js
@@ -756,7 +756,7 @@ var onMainDocHeadersReceived = function(details) {
     // inject CSP for XML documents, rather then not inject CSP if not a 
     // HTML document in order to limit to a minimum the change in behavior.
     i = headerIndexFromName('content-type', headers);
-    if ( i === -1 || headers[i].value.search('text/xml') !== -1 ) {
+    if ( i !== -1 && headers[i].value.indexOf('text/xml') !== -1 ) {
         return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -756,7 +756,7 @@ var onMainDocHeadersReceived = function(details) {`
`756`	`756`	`// inject CSP for XML documents, rather then not inject CSP if not a`
`757`	`757`	`// HTML document in order to limit to a minimum the change in behavior.`
`758`	`758`	`i = headerIndexFromName('content-type', headers);`
`759`		`- if ( i === -1 \|\| headers[i].value.search('text/xml') !== -1 ) {`
	`759`	`+ if ( i !== -1 && headers[i].value.indexOf('text/xml') !== -1 ) {`
`760`	`760`	`return;`
`761`	`761`	`}`
`762`	`762`