Parse WHERE clause using ANTLR #749
Conversation
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
This already looks very nice. I gave it a first long round of reviews, let me know when you want to talk about any of it.
Co-authored-by: joka921 <joka921@users.noreply.github.com>
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
Very nice, this is really getting in shape.
I have left some remarks, and some of this we should maybe discuss in person.
But I think you should have enough to do:)
Co-authored-by: joka921 <joka921@users.noreply.github.com>
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
This is almost done. We have already tried this out yesterday and especially @hannahbast liked it very much. There is one slight issue with the new way you call addLanguageFilter but that is because that function was always kind of broken and will already be fixed before this gets merged (not your fault).
Co-authored-by: joka921 <joka921@users.noreply.github.com>
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
Really nice,
I think we are converging towards merging:)
Co-authored-by: joka921 <joka921@users.noreply.github.com>
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
Great! This is a very important milestone towards more correct and cleaner parsing!
|
@Qup42 BTW, I already told Johannes, but I didn't tell you yet, Julian: Thank you very much for your work on this PR and the associated ones! It's a major milestone for QLever. In particular, it allowed me a happy update of this page: https://github.com/ad-freiburg/qlever/wiki/Current-deviations-from-the-SPARQL-1.1-standard . And it's the basis for many other improvements that had to wait so far because we didn't have a proper SPARQL parser. |
3 participants
Parse
whereClausein ANTLR. This is one fairly big connected chunk of the grammar.The parsing should already work. It is live in the
SparqlParser.TODO:
std::pair<...>return types into structs.valuesClause