SPARQL Update Part 1: Located Triples #1379
Conversation
|
This PR will run somewhat parallel to #1351. To keep it in sync I will cherry-pick the changes made here back to it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
+ Coverage 89.06% 89.22% +0.16%
==========================================
Files 328 335 +7
Lines 29294 29722 +428
Branches 3262 3313 +51
==========================================
+ Hits 26090 26519 +429
+ Misses 2054 2045 -9
- Partials 1150 1158 +8 ☔ View full report in Codecov by Sentry. |
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
Some preliminary comments, haven't looked at everything yet.
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
Some additional suggestions and discussions.
|
@joka921 whats the usual procedure for the coverage of debugging |
It will only be required for the integration.
# Conflicts: # test/util/IdTestHelpers.h
This reverts commit 70757a4.
# Conflicts: # src/index/Permutation.h
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
I still have some questions, but those can be easily addressed.
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
I have one remaining question/suggestion.
|
Since #1379, the located triples for each permutation have their own "augmented" block metadata (an update can change the first or last triple of a block). But so far, all index scan operations still use the original block metadata. Now they use the augmented block metadata when appropriate. For the two internal permutations, we assume that they are not affected by updates and we always use their original block metadata.
2 participants
This is the first PR in a series of PRs that will implement SPARQL UPDATE for QLever.
It implements
LocatedTriples. These are triples that know to which block in a given permutation they belong to and whether they are to be inserted or deleted. They come with the functionality to find the corresponding blocks for a set of triples (to turn them intoLocatedTriplesas well as the functionality to merge a block from a permutation with all theLocatedTriplesthat belong to this block. The latter function is the core functionality to incorporate the results of an UPDATE into subsequent queries.