Implement functions UUID() and STRUUID()
#1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com>
Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com>
Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com>
Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com>
…neral implementation
Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com>
Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com>
…ng correct prefix in Constants.h
Collaborator
Author
|
Should the urn:uuid for the Iri be defined in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1366 +/- ##
==========================================
- Coverage 88.89% 88.88% -0.01%
==========================================
Files 326 327 +1
Lines 28992 29034 +42
Branches 3214 3217 +3
==========================================
+ Hits 25773 25808 +35
- Misses 2066 2068 +2
- Partials 1153 1158 +5 ☔ View full report in Codecov by Sentry. |
joka921
requested changes
Jun 10, 2024
Member
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
Some very minor suggestions, overall this looks good!
|
|
||
| using LiteralOrIri = ad_utility::triple_component::LiteralOrIri; | ||
|
|
||
| inline constexpr auto fromLiteral = [](std::string_view str) { |
Member
There was a problem hiding this comment.
inlineis redundant forconstexprvalues, so it can be dropped.- Those inline functions are a bit prone to multiple definition errors etc, better move them into a namespace
sparqlExpression::uuidExpression::detailor something.
Collaborator
Author
There was a problem hiding this comment.
Somehow the tests for builtInCall don't pass if i remove the inline.
joka921
requested changes
Jun 13, 2024
Member
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
Only a very very minor change left.
|
joka921
approved these changes
Jun 13, 2024
joka921
changed the title
UUID() and STRUUID()
realHannes
added a commit
to realHannes/qlever
that referenced
this pull request
Jun 15, 2024
These functions generate a random UUID for each invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions generate a random UUID for each invocation.