Small refactorings as preparation for UPDATE queries #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid duplication this change will only be in ad-freiburg#1354
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 88.79% 88.79% -0.01%
==========================================
Files 324 324
Lines 28650 28653 +3
Branches 3170 3171 +1
==========================================
+ Hits 25441 25442 +1
- Misses 2060 2062 +2
Partials 1149 1149 ☔ View full report in Codecov by Sentry. |
joka921
requested changes
May 22, 2024
Member
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
I have a very small suggestion that would be very useful ( a longstanding issue, that can help us with debugging.
joka921
approved these changes
May 22, 2024
joka921
changed the title
|
|
"Update queries" are not a thing, they're just "updates" :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of smaller refactoring changes, most of which come from an early proof of concept implementation of SPARQL UPDATE by @hannahbast.
Those include:
ValueIds shorter (V:3rater thanVocabindex:3).