Implement IN and NOT IN
#1344
Merged
Implement IN and NOT IN
#1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe later.
Figure out the constantness of the result...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
+ Coverage 88.95% 88.99% +0.04%
==========================================
Files 329 329
Lines 29090 29155 +65
Branches 3230 3236 +6
==========================================
+ Hits 25877 25947 +70
+ Misses 2060 2055 -5
Partials 1153 1153 ☔ View full report in Codecov by Sentry. |
correct behavior with SetOfIntervals.
# Conflicts: # src/parser/sparqlParser/generated/SparqlAutomaticParser.cpp
# Conflicts: # test/SparqlAntlrParserTest.cpp
hannahbast
changed the title
IN and NOT IN
# Conflicts: # src/engine/sparqlExpressions/LiteralExpression.h # src/engine/sparqlExpressions/SparqlExpressionTypes.h # src/util/Views.h
hannahbast
requested changes
Jun 27, 2024
Member
hannahbast
left a comment
hannahbast
left a comment
There was a problem hiding this comment.
1-1 with Johannes, this looks great and works fine, some minor changes left
hannahbast
approved these changes
Jun 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.