Implement the SUBSTR function #1057
Conversation
SEVERAL TODOS: * Tests * Corner case of negative start * Prepare the infrastructure for several other string expressions.
TODO<joka921> Tests for the parsing.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 78.26% 78.33% +0.06%
==========================================
Files 275 276 +1
Lines 25678 25770 +92
Branches 3143 3154 +11
==========================================
+ Hits 20098 20188 +90
- Misses 4378 4379 +1
- Partials 1202 1203 +1
☔ View full report in Codecov by Sentry. |
hannahbast
left a comment
hannahbast
left a comment
There was a problem hiding this comment.
This looks great, I only have a small question.
test/SparqlAntlrParserTest.cpp
Outdated
| matchNaryWithChildrenMatchers( | ||
| &makeSubstrExpression, variableExpressionMatcher(V{"?x"}), | ||
| idExpressionMatcher(IntId(7)), | ||
| idExpressionMatcher(IntId(576460752303423487)))); |
There was a problem hiding this comment.
Why can't this number be computed from constants in ValueId?
hannahbast
changed the title
|
Suggestion for commit message: First implementation of a non-trivial string function. |
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
No description provided.