Repository navigation
Conversation
Co-Authored-By: Clanker
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9161 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 139 139
Lines 4071 4071
=======================================
Hits 4035 4035
Misses 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveAdmin 3 rendered every flash key as
div.flash.flash_<type>. The v4_flash_messagespartial only renderserror,alertandnotice, so any other key, such asflash[:warning], is dropped without a trace. This PR renders every key again.Motivating case: activeadmin-plugins/active_admin_filter_extensions#9 had to move its
:warningflash to:alertand override this partial in its test app to work on v4.Decisions:
warninguses the alert (yellow) style andsuccessuses the notice (green) style, since both names are common in Rails apps.data-flash-type="<type>", so tests and themes can target a type without matching Tailwind color classes.flash_messagesfiltering (flash_keys_to_except,timedout) is untouched.Verification: new specs in
spec/helpers/layout_helper_spec.rbrender the partial (they fail without the change); rubocop and typos pass.