Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9152 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 139 139
Lines 4071 4071
=======================================
Hits 4035 4035
Misses 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
17 of 22 tasks
senid231
force-pushed
the
header-height
branch
from
November 12, 2026 11:20
7f2ca9c to
767cb47
Compare
Contributor
Author
|
CI failed only in the Could a maintainer re-run the failed job? I don't have permission to. |
The header height was hardcoded as h-16 in the header, the layout padding and the side menu offset, so a theme with a shorter header had to copy all three files. Co-Authored-By: Clanker
senid231
force-pushed
the
header-height
branch
from
November 13, 2026 08:31
767cb47 to
f3e05ba
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--aa-header-heightCSS variable, set by the plugin tocalc(var(--spacing) * 16). Three places hardcoded the same height ash-16: the site header, the layout's top padding, and the side menu's top offset. They now read the variable.A theme with a shorter header sets the variable in
active_admin.cssinstead of copying the layout, the header, and the navigation.Part of #9146. The computed sizes are unchanged. The HTML differs only in the class names.