Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9151 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 139 139
Lines 4071 4071
=======================================
Hits 4035 4035
Misses 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
17 of 22 tasks
The main menu switched from drawer to side menu at a hardcoded xl, so a theme had to copy the layout, header and navigation to change it. The variant defaults to the same 80rem, and a host redeclares it in CSS. Co-Authored-By: Clanker
senid231
force-pushed
the
menu-breakpoint-variant
branch
from
November 12, 2026 11:20
1004705 to
c4629de
Compare
Contributor
Author
|
CI failed only in the Could a maintainer re-run the failed job? I don't have permission to. |
The docs already show the override example, so the plugin comment keeps one line. Co-Authored-By: Clanker
senid231
force-pushed
the
menu-breakpoint-variant
branch
from
November 13, 2026 08:31
c4629de to
a4c9ffc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
aa-menuvariant to the Tailwind plugin and uses it instead ofxl:for the main menu. Below that width the menu is a drawer, and from that width up it is a fixed side menu.The variant defaults to
@media (width >= 80rem), the same asxl. A host changes it inactive_admin.csswithout copying any view:@media not allkeeps the drawer at every width, for themes that move navigation into the header.I used
addVariantrather than ascreensentry, because a new screen also adds a step to.container's max width.Part of #9146. The compiled CSS has the same rules as before, but the
aa-menurules sort after the built-in breakpoints. None of them conflicts with a later utility on the same element. The HTML differs only in the class names.