Skip to content

Extract page content, heading, breadcrumbs and title partials - #9150

Open
senid231 wants to merge 1 commit into
activeadmin:masterfrom
senid231:page-content-partials
Open

senid231 wants to merge 1 commit into
activeadmin:masterfrom
senid231:page-content-partials

Conversation

@senid231

@senid231 senid231 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Extracts partials from the layout and the page header:

  • _page_content: the grid that holds yield and the sidebar. A theme that puts the sidebar first or wraps the content no longer copies the layout.
  • _page_heading: the column with _breadcrumbs and _page_title. A theme can restyle any of the three without copying _page_header. The action items were already a partial.

The page header gains id="page-header" and its action items wrapper gains id="action-items", so a theme can restyle them without relying on the data-test-* attributes. yield inside _page_content returns the page body, the same as it does in the layout.

Part of #9146. I compared the rendered dashboard and index pages before and after. The only differences are the new ids.

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (e1dad93) to head (fdef53e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9150   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         139      139           
  Lines        4071     4071           
=======================================
  Hits         4035     4035           
  Misses         36       36           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

A theme that reorders the sidebar or restyles the page heading had to copy
the layout or the whole page header. The page header and action items get
ids so a theme can restyle them without copying them.

Co-Authored-By: Clanker
@senid231
senid231 force-pushed the page-content-partials branch from 9302aba to fdef53e Compare November 12, 2026 11:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant