Allow config.paginate to be a block#8007
Open
allomov wants to merge 2 commits intoactiveadmin:masterfrom
Open
Conversation
Author
|
I am not sure why CI is failing, because the same command for test (3.2, rails_70) and other configurations work fine, but fail on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8007 +/- ##
==========================================
+ Coverage 98.84% 99.11% +0.26%
==========================================
Files 197 197
Lines 4950 4949 -1
==========================================
+ Hits 4893 4905 +12
+ Misses 57 44 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, everyone!
I propose this change to allow
config.paginateoption to be set as a block that will return a value based on resource configuration.In my case, I have a Sessions resource with an index that can be displayed as a table (default view) and as a calendar. With the calendar view, the pagination is replaced by the start/end time filter.
Using this change I can initialize resources in the following way:
which will allow
ActiveAdmin::Views::IndexAsCalendarwill handle filtering instead of pagination.Thank you for your attention! Please, tell me what you think about it.