Interesting. This dependency was introduced by #5811 The latest publisher of db-query-matchers is still active using Ruby on GitHub so I think too soon to say abandoned.

Is this dependency worth though? It is only used in two tests, which can be easily rewritten to check the same thing. For example we could subscribe to the active_record.sql notification in those tests and check if the queries we don't want to be there are not there.

If we can do the same thing through ActiveRecord notification subscription, I'd be ok with that and would approve. Ideally, we'd still want the database query check for these test cases.

If we can do the same thing through ActiveRecord notification subscription

That is how db-query-matchers is implemented.

I agree we should keep the SQL check.

@alejandroperea do you want to improve the test to use the ActiveSupport::Notification.subscribe('sql.active_record')?

@rafaelfranca Sure! I'll take a look this weekend 👍

@rafaelfranca Done! It is the first time I use ActiveSupport::Notifications (super cool, btw), I hope I did it properly 🙏

I've added an Rspec matcher for doing this, just in case we want to use it in another place in the future.

I agree @deivid-rodriguez ! Change applied 👍

Thanks for the review! :)

Thanks so much!!