Fix filter_columns_for_large_association and filter_method_for_large_association examples#6232
Merged
deivid-rodriguez merged 1 commit intoactiveadmin:masterfrom May 18, 2020
Conversation
…association examples in install/templates/active_admin.rb.erb
Member
|
Thanks! ❤️ |
deivid-rodriguez
added
type enhancement
type: documentation
and removed
type enhancement
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was just checking out the new
maximum_association_filter_arity,filter_columns_for_large_association,filter_method_for_large_associationoptions from #5548, which look like they will be a huge help! I thinkmaximum_association_filter_arityshould definitely be set to a sane maximum by default.I copied these lines into my
config/initializers/active_admin.rband uncommented them, and saw that there was a syntax error. (,should be=). So I just thought I would send a PR to fix that!