fix CSVBuilder not respecting global ":humanize_name" setting#5800
Conversation
|
@HappyKadaver We have setup for that in https://github.com/activeadmin/activeadmin/blob/97e48ece25b5ea534183f47acc68dda8f9e58e76/features/index/format_as_csv.feature, so you can probably add a scenario in there. |
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Just some tiny comments, but it looks great otherwise!
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Can you also add a new changelog entry for this bug fix? Thanks!!
HappyKadaver
force-pushed
the
fix_csv_builder_humanize_name_global_default
branch
5 times, most recently
from
8966a72 to
6ce06c8
Compare
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Just a tiny comment.
HappyKadaver
force-pushed
the
fix_csv_builder_humanize_name_global_default
branch
from
6ce06c8 to
b6e8487
Compare
HappyKadaver
force-pushed
the
fix_csv_builder_humanize_name_global_default
branch
from
b6e8487 to
3bf12d9
Compare
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Oh, sorry. This didn't make it to the 2.2.0 release in the end, so we need to move the changelog entry under a new ### Bug Fixes section under ## Unreleased.
HappyKadaver
force-pushed
the
fix_csv_builder_humanize_name_global_default
branch
from
3bf12d9 to
975560b
Compare
|
🤣 I hope I didn't take to much of your time. You have a really nice testing setup. The actual tests on the Changelog did catch me off guard but now we should have it. 😆 |
|
Looks great. 👌🏻 Thanks to you both for finishing this! ❤️ We'll get this in now. |
add features testing global csv humanize_name setting
add features testing global csv humanize_name setting
3 participants
fix CSVBuilder not respecting default ":humanize_name" setting in "ActiveAdmin.application.csv_options"
change two test cases to allow for extra options in CSVBuilder as long as it assumes any options directly passed to the initializer
fixes #5799
If someone can tell me how I can set ActiveAdmin.application.csv_options for a single spec without affecting other specs I will add some tests for this.