Gherkin lint #5636
Merged
Gherkin lint #5636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
gherkin_lint
branch
from
0bb82c2 to
e26a7ec
Compare
deivid-rodriguez
force-pushed
the
gherkin_lint
branch
from
e26a7ec to
9f62708
Compare
javierjulio
approved these changes
Dec 9, 2018
Member
javierjulio
left a comment
javierjulio
left a comment
There was a problem hiding this comment.
My only concern was using node and updating CI but I remember you had updated the base image to include node recently so we are good. Thanks! 👍🏻
Member
Author
Yeah, I had the same concern, but I noticed that I needed to add it to the lint job in 3da2364, so I guess it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sometimes make comments on PRs that add cucumber features about little inconsistencies in the style (for example, #5548 (comment)). I'd like a basic gherkin style to be enforced automatically, so this is what this PR does.