Skip to content

Release/1.2.1#5314

Merged
varyonic merged 2 commits into1-2-stablefrom
release/1.2.1
Jan 10, 2018
Merged

Release/1.2.1#5314
varyonic merged 2 commits into1-2-stablefrom
release/1.2.1

Conversation

@varyonic
Copy link
Contributor

Backport #5299 fix to XSS patch.

faucct and others added 2 commits January 9, 2018 19:58
Adapt unit tests for copied helper
DisplayHelper should not sanitize its input
Filters sidebar should not be vulnerable to XSS
@codecov
Copy link

codecov bot commented Jan 10, 2018

Codecov Report

Merging #5314 into 1-2-stable will increase coverage by <.01%.
The diff coverage is 98.59%.

Impacted file tree graph

@@              Coverage Diff               @@
##           1-2-stable    #5314      +/-   ##
==============================================
+ Coverage       97.99%   97.99%   +<.01%     
==============================================
  Files             283      285       +2     
  Lines           10996    11059      +63     
==============================================
+ Hits            10775    10837      +62     
- Misses            221      222       +1
Impacted Files Coverage Δ
spec/unit/view_helpers/display_helper_spec.rb 100% <ø> (ø) ⬆️
spec/unit/helpers/output_safety_helper_spec.rb 100% <100%> (ø)
lib/active_admin/view_helpers/display_helper.rb 98.07% <100%> (ø) ⬆️
...b/active_admin/views/components/sidebar_section.rb 100% <100%> (ø) ⬆️
lib/active_admin/filters/active_sidebar.rb 100% <100%> (ø) ⬆️
spec/unit/pretty_format_spec.rb 100% <100%> (ø) ⬆️
lib/active_admin/helpers/output_safety_helper.rb 92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf01e76...f3bdb7c. Read the comment docs.

@varyonic varyonic merged commit fed8657 into 1-2-stable Jan 10, 2018
@varyonic varyonic deleted the release/1.2.1 branch January 12, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants