HTML encode display_name output.#5284
Merged
varyonic merged 2 commits intoactiveadmin:masterfrom Dec 15, 2017
markstory:display-name
Merged
HTML encode display_name output.#5284varyonic merged 2 commits intoactiveadmin:masterfrom markstory:display-name
varyonic merged 2 commits intoactiveadmin:masterfrom
markstory:display-name
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5284 +/- ##
==========================================
- Coverage 98.28% 98.27% -0.01%
==========================================
Files 292 292
Lines 10893 10900 +7
==========================================
+ Hits 10706 10712 +6
- Misses 187 188 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The display_name helper can end up invoking methods on ActiveRecord models or other arbitrary ruby objects that can contain unsafe user supplied data resulting in XSS holes.
Refs #5198
Refs #5265
Refs #5275