Skip to content

Update terminology in setup-python - #46

Merged
konradpabjan merged 8 commits into
actions:masterfrom
brcrista:brcrista/old-references
Dec 30, 2019
Merged

konradpabjan merged 8 commits into
actions:masterfrom
brcrista:brcrista/old-references

Conversation

@brcrista

Copy link
Copy Markdown
Contributor

Some of the comments are using outdated terminology. I also took the chance to touch up the contributor guidelines.

Comment thread dist/index.js
/******/ function startup() {
/******/ // Load entry module and return exports
/******/ return __webpack_require__(429);
/******/ return __webpack_require__(264);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran with version 0.20.5 of ncc.

Comment thread action.yml Outdated
inputs:
python-version:
description: 'Version range or exact version of a Python version to use, using semvers version range syntax.'
description: 'Version range or exact version of a Python version to use, using SemVer's version range syntax.'

@brcrista brcrista Dec 27, 2019 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SemVer stylizes its name as such. See https://semver.org/#semantic-versioning-specification-semver

Comment thread yaml-lint-config.yml

rules:
# 80 chars should be enough, but don't fail if a line is longer
# 120 chars should be enough, but don't fail if a line is longer

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had tried spreading the description, etc., across multiple lines, but I decided it would probably be better to raise the limit. Monitors have gotten bigger since the days of the 80-char guideline, so I think 120 is a good number today.

@brcrista

Copy link
Copy Markdown
Contributor Author

@konradpabjan I just noticed we don't run the main workflow on pull requests. Do you want me to enable it?

@konradpabjan konradpabjan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brcrista

Copy link
Copy Markdown
Contributor Author

@konradpabjan can you merge? I don't have write access to this repo.

@konradpabjan
konradpabjan merged commit f907029 into actions:master Dec 30, 2019
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants