Repository navigation
Remove node modules and configure ncc - #35
Conversation
|
A lot of changes here since I ended up deleting
Also relavent
|
|
With early documentation, we often recommended using actions at master ( Do we know how many users are using this action on the master branch? Are we prepared/willing to break all of those users? If not, we can just put |
|
@joshmgross to your earlier comment, from #11:
@konradpabjan have we deprecated master yet? |
The plan all along was to put What's described at the top of #11, is no longer 100% accurate. Originally |
So we're not going to be deprecating master. I makes it possible for people to use it and test it out early if they really want. It also just seems weird to always have a not working action in the master branch. What we could do is add a warning message inside |
I see, I missed it in the big set of files in the PR 👍 |
joshmgross
left a comment
There was a problem hiding this comment.
Have you run a test using setup-python@konradpabjan/ncc?
Yup, see the screenshot attached in the top description 😃 |
Remove node modules and configure ncc
Relevant Issue: #11
Removing
node_modules/andlib/from the master branch. In the releases branch,nccis now being used to compile all of the necessary files into a single filedist/index.jsGoing off of examples here: https://github.com/actions/cache/blob/releases/v1/package.json and here: actions/javascript-action#5
Tested in private repository with existing action:
uses: actions/setup-python@v1and with the new changesuses: actions/setup-python@konradpabjan/ncc, and confirming that it is working as expected:Full yaml:
Passing runs