Revert "Enhance cache-dependency-path handling to support files outside the workspace root"#1186
Merged
HarithaVattikuti merged 2 commits intomainfrom Aug 28, 2025
Merged
Conversation
…de the w…" This reverts commit 1264885.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts commit 1264885 which enhanced cache-dependency-path handling to support files outside the workspace. The functionality is being reimplemented at the actions/toolkit level for better consistency across actions.
Key changes:
- Removes complex file copying logic from the cacheDependencies function
- Eliminates associated test coverage for the removed functionality
- Removes documentation note about support for files outside workspace
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/setup-python.ts | Reverts cacheDependencies function to simpler implementation without file copying logic |
| docs/advanced-usage.md | Removes documentation note about cache-dependency-path supporting files outside workspace |
| tests/setup-python.test.ts | Removes all test cases for the reverted file copying functionality |
| .github/workflows/test-pypy.yml | Adds windows-2019 to test matrix (unrelated change) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aparnajyothi-y
changed the title
priya-kinthali
previously approved these changes
Aug 26, 2025
priyagupta108
previously approved these changes
Aug 26, 2025
aparnajyothi-y
dismissed stale reviews from priyagupta108 and priya-kinthali
via
558ecb0
priya-kinthali
approved these changes
Aug 26, 2025
priyagupta108
approved these changes
Aug 26, 2025
HarithaVattikuti
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1264885.
Description:
Reverts PR #1128. That change copied a file from the composite action into the workspace to support composite actions, but we’ve decided to implement this capability at the actions/toolkit level instead (see actions/toolkit#1035) for a more consistent and scalable solution.