Skip to content

Allow using .tool-versions for node-version-file #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deiga wants to merge 1 commit into from
Closed

Allow using .tool-versions for node-version-file #445

deiga wants to merge 1 commit into from

Conversation

@deiga
Copy link

@deiga deiga commented Mar 15, 2022

Description:
Add parsing of .tool-versions file format.
This enables developers which use asdf to use their version file to
steer which version of node to install.
This change should be fully backwards compatible as it only does things
if a certain string is found in the node-version-file

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@deiga
Allow using .tool-versions for node-version-file
bd33d2e 
This enables developers which use `asdf` to use their version file

Signed-off-by: Timo Sand <timo.sand@iki.fi>
@deiga deiga requested a review from a team March 15, 2022 20:46
@brcrista
Copy link
Contributor

brcrista commented Mar 16, 2022

Hey @deiga, thanks for the PR. This is my first time hearing about asdf, but I think the approach makes sense. If I'm understanding correctly, you don't actually have to install asdf on the build machine; this is just adding support for its syntax. Is that right?

Since this is a new feature, if you're able to put together a minimal workflow that uses deiga/setup-node, that would go a long way towards helping us see how it works.

@runlevel5
Copy link

runlevel5 commented Jun 23, 2022

Thanks for the PR, we are also using asdf for our projects (due to mix-tech nature). Love to see this PR going in

@IvanZosimov
Copy link
Contributor

IvanZosimov commented Jun 23, 2022

@deiga, 👋 Just a gentle ping 💌

@snyk-bot snyk-bot mentioned this pull request Aug 20, 2022
Open
@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Sep 8, 2022

Hello @deiga. Thank you for your pull request. For now I'm going to close the pull request because the logic was implemented in this pull request. If you have any concerns feel free to ping us.

@deiga deiga deleted the enable-asdf-node-version-file branch September 8, 2022 17:57
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
@dependabot
chore(deps-dev): bump all-contributors-cli from 6.23.1 to 6.24.0 (act…
b3fb60f 
…ions#445)

Bumps [all-contributors-cli](https://github.com/all-contributors/all-contributors-cli) from 6.23.1 to 6.24.0.
- [Release notes](https://github.com/all-contributors/all-contributors-cli/releases)
- [Commits](all-contributors/cli@v6.23.1...v6.24.0)

---
updated-dependencies:
- dependency-name: all-contributors-cli
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deiga @brcrista @runlevel5 @IvanZosimov @dmitry-shibanov