Update tool-cache for download retries#120
Conversation
ericsciple
force-pushed
the
users/ericsciple/m167retry
branch
2 times, most recently
from
a66ea3f to
14be2d2
Compare
|
|
||
| const rcFile = path.join(tempDir, '.npmrc'); | ||
|
|
||
| process.env['GITHUB_REPOSITORY'] = 'OwnerName/repo'; |
There was a problem hiding this comment.
moved this code that sets env vars into beforeAll
| const path = __importStar(__webpack_require__(622)); | ||
| const httpm = __importStar(__webpack_require__(539)); | ||
| const semver = __importStar(__webpack_require__(280)); | ||
| const stream = __importStar(__webpack_require__(794)); |
There was a problem hiding this comment.
skip reviewing this file, this is the dist
| 'temp' | ||
| ); | ||
|
|
||
| process.env['RUNNER_TOOL_CACHE'] = toolDir; |
There was a problem hiding this comment.
moved to beforeAll
| import * as installer from '../src/installer'; | ||
|
|
||
| const IS_WINDOWS = process.platform === 'win32'; | ||
| const isWindows = process.platform === 'win32'; |
There was a problem hiding this comment.
this variable had inconsistent naming from the style used everywhere else in this action :)
| @@ -1,5 +1,3 @@ | |||
| // Load tempDirectory before it gets wiped by tool-cache | |||
| let tempDirectory = process.env['RUNNER_TEMPDIRECTORY'] || ''; | |||
There was a problem hiding this comment.
RUNNER_TEMPDIRECTORY isnt a thing :(
There was a problem hiding this comment.
i tested adding the action twice, and the first downloads and the second reuses the cache as expected. So not sure what the "wiped" comment used to mean.
| ): Promise<string> { | ||
| // Create temporary folder to download in to | ||
| let tempDownloadFolder: string = | ||
| const tempDownloadFolder: string = |
There was a problem hiding this comment.
This looks like a gap in coverage. Adding an E2E test for this.
ericsciple
force-pushed
the
users/ericsciple/m167retry
branch
from
6f9cbc3 to
5fb96a5
Compare
|
3 participants
No description provided.