Add more robust support for EA version specification #35
Conversation
This will support specifying EA versions in the following format examples. E.g.: 14-ea 14.0.0-ea 14.0.0-ea.28 Notes: - For the last form above, which is needed for requesting a specific ea build, we must only add '.x' if there are less than 3 dots in the version, hence the change from != 3 to < 3 - The prior parsing logic for e.g. 14.0.0-ea "spelling" will ignore precedence between build numbers in the form of e.g. 14.0.0-ea+b27 vs. 14.0.0-ea+b27 (so it will end up with the earliest rather than the latest ea build in the cdn), and does not allow specifying an ea build number (it will match 14.0.0-ea+b29 to a cdn 14.0.0-ea+b2). The new logic [copupled with the CDN populating EA builds in the form 14.0.0-ea.28) will resolve that.
konradpabjan
left a comment
konradpabjan
left a comment
There was a problem hiding this comment.
Looks good 👍 Thanks for this!
I think an update to the README would be good as well with some example YAML to illustrate how to use the java versions that have a slightly different syntax
|
Agreed on the README, but I'd like to add the README examples separately, after we get out a version that would allow the CDN to hold more than one EA build at a time. The reason is that in the README, I would want to show how to specify a specific EA build version (e.g. 14.0.0-ea.27 vs. 14.0.0-ea.28), but for now, to get around the issue this pull request fixes, we've been "hiding" the older versions on the CDN such that only the one version appears at a time (otherwise only the earliest build would be picked up by the current logic). |
Add more robust support for EA version specification
2 participants
These changes will address #34 and add support specifying EA versions in the following format examples. E.g.:
14-ea
14.0.0-ea
14.0.0-ea.28