Skip to content

docs: add JavaFX Maven project configuration instructions#1044

Merged
brunoborges merged 3 commits into
mainfrom
copilot/add-config-instructions-javafx-maven
Jun 22, 2026
Merged

docs: add JavaFX Maven project configuration instructions#1044
brunoborges merged 3 commits into
mainfrom
copilot/add-config-instructions-javafx-maven

Conversation

Copilot AI commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No documentation existed for using setup-java with JavaFX Maven projects, despite the feature being supported via java-package: jdk+fx.

Changes:

  • Added ### JavaFX Maven project subsection under ## Installing custom Java package type in docs/advanced-usage.md
    • Explains use of java-package: jdk+fx (or jre+fx) with supported distributions (zulu, liberica)
    • References the openjfx.io Getting Started guide for pom.xml setup
    • Includes workflow snippets for mvn compile and mvn javafx:run
  • Updated table of contents to include the new subsection

Example workflow snippet:

- uses: actions/setup-java@v5
  with:
    distribution: 'zulu'
    java-version: '21'
    java-package: jdk+fx
    cache: maven
- name: Build with Maven
  run: mvn --no-transfer-progress compile

Related issue:
Closes #568

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copilot AI changed the title [WIP] Docs: Add config instructions for JavaFX Maven project docs: add JavaFX Maven project configuration instructions Jun 22, 2026
Copilot AI requested a review from brunoborges June 22, 2026 21:44
@brunoborges brunoborges added the documentation Improvements or additions to documentation label Jun 22, 2026
@brunoborges brunoborges marked this pull request as ready for review June 22, 2026 22:03
@brunoborges brunoborges requested a review from a team as a code owner June 22, 2026 22:03
Copilot AI review requested due to automatic review settings June 22, 2026 22:03
@brunoborges brunoborges merged commit 5431e71 into main Jun 22, 2026
1 check passed
@brunoborges brunoborges deleted the copilot/add-config-instructions-javafx-maven branch June 22, 2026 22:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds missing documentation for using actions/setup-java with JavaFX Maven projects by describing the supported java-package variants (jdk+fx / jre+fx) and providing Maven workflow snippets.

Changes:

  • Added a new “JavaFX Maven project” subsection under “Installing custom Java package type”.
  • Documented using java-package: jdk+fx with supported distributions (e.g., zulu, liberica) and linked to OpenJFX Maven setup guidance.
  • Updated the table of contents to include the new subsection.
Show a summary per file
File Description
docs/advanced-usage.md Adds a JavaFX+Maven documentation subsection, including example GitHub Actions steps and TOC entry.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

Comment thread docs/advanced-usage.md
java-package: jdk+fx
cache: maven
- name: Build with Maven
run: mvn --no-transfer-progress compile
Comment thread docs/advanced-usage.md

```yaml
- name: Run with Maven
run: mvn --no-transfer-progress javafx:run
Comment thread docs/advanced-usage.md
run: mvn --no-transfer-progress compile
```

To run the JavaFX application in CI:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Add config instructions on JavaFX Maven project

3 participants