Skip to content

Clarify README version syntax and migration guidance#1038

Merged
brunoborges merged 2 commits into
mainfrom
copilot/fix-readme-clarifications
Jun 22, 2026
Merged

Clarify README version syntax and migration guidance#1038
brunoborges merged 2 commits into
mainfrom
copilot/fix-readme-clarifications

Conversation

Copilot AI commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description:
The README could be read as if only a small fixed set of Java major versions were supported, and its version-migration note referenced only V1 vs V2 despite later examples using newer action majors.

  • Version syntax clarification

    • Explicitly states that the listed java-version values are examples, not an exhaustive list.
    • Rewords the major-version bullets to make the examples illustrative rather than restrictive.
  • Migration guidance placement

    • Moves the V2 vs V1 section later in the README, after the main usage guidance.
    • Clarifies that while examples now use actions/setup-java@v5, the key V1→V2 behavioral change still applies to later majors (v3-v5).
  • Example

    #### Supported version syntax
    The `java-version` input supports an exact version or a version range using SemVer notation. The values below are examples, not an exhaustive list:
    - major versions, such as: `8`, `11`, `16`, `17`, `21`, `25`

Related issue:
#481

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@brunoborges brunoborges added the documentation Improvements or additions to documentation label Jun 22, 2026
Copilot AI changed the title [WIP] Update README to clarify version details Clarify README version syntax and migration guidance Jun 22, 2026
Copilot AI requested a review from brunoborges June 22, 2026 17:45
@brunoborges brunoborges marked this pull request as ready for review June 22, 2026 17:53
@brunoborges brunoborges requested a review from a team as a code owner June 22, 2026 17:53
@brunoborges brunoborges requested review from Copilot and gdams June 22, 2026 17:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the actions/setup-java README to reduce confusion around supported java-version values and to place V1→V2 migration guidance in a more appropriate spot, aligning the docs with the action’s current major version (v5) while keeping the historical breaking-change note relevant.

Changes:

  • Clarifies that the listed java-version values are illustrative examples, not an exhaustive supported set.
  • Rewords the “major versions” bullet to emphasize example syntax rather than a fixed list.
  • Moves the “V2 vs V1” section later in the README and clarifies that the V1→V2 behavior change still applies to later majors (v3v5).
Show a summary per file
File Description
README.md Clarifies java-version example syntax and relocates/updates V1→V2 migration guidance for readers using actions/setup-java@v5.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@brunoborges brunoborges merged commit c09b25f into main Jun 22, 2026
1 check passed
@brunoborges brunoborges deleted the copilot/fix-readme-clarifications branch June 22, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants