docker: Do not overwrite entrypoint if it has already been set or if it is Service container #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #44
When using service container with container hooks for docker, is it possible to stop the overwriting of the entrypoint?
Currently, container hooks for docker does not allow the use of service container for some docker images.
This is because the setupContainer function sets
tailas entryPoint field in any case.This behavior prevents, for example, postgres or mysql cannot be started (by overriding their configured entrypoint).
setupContainer function:
runner-container-hooks/packages/docker/src/hooks/prepare-job.ts
Lines 178 to 179 in ebbe2bd
I think this is the same problem as #44. So, I tried to write a patch based on #45.
I didn't know why the entrypoint was overwritten initially, so if you have a workaround, I would appreciate it if you could let me know.