k8s: handle $ symbols in environment variable names and values #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
k8s-env
branch
2 times, most recently
from
9c16145 to
7016bf8
Compare
aibaars
force-pushed
the
k8s-env
branch
2 times, most recently
from
afc3810 to
0ad0f12
Compare
aibaars
changed the title
aibaars
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, environment variables like:
would wrongly get expanded by the shell when running a job via the k8s scripts. This may lead to errors like:
See a complete log for context: https://github.com/matihost/monorepo/actions/runs/4638170156/jobs/8207744339
This pull request:
$is used in the name of an environment variable$symbols in the value of an environment variableThis behaviour is the same as other special shell characters such as
'and".