Skip to content

Conversation

@nikola-jokic
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings July 15, 2025 12:24
@nikola-jokic nikola-jokic requested a review from a team as a code owner July 15, 2025 12:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades various dependencies across the monorepo, adjusts Kubernetes client calls to the new object-parameter API, and updates test/jest configurations for compatibility with ESM and TS-Jest.

  • Bump package versions in packages/k8s, packages/docker, and packages/hooklib
  • Refactor all k8sApi/k8sBatchV1Api calls to use the { name, namespace, body } signature
  • Enhance Jest configs (ts-jest preset, Babel transforms, ESM module handling)

Reviewed Changes

Copilot reviewed 21 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/k8s/tsconfig.json Added esModuleInterop and expanded include to src/**/*
packages/k8s/tests/test-setup.ts Refactored cleanup calls to new client signature
packages/k8s/src/k8s/index.ts Converted all create/read/delete calls to object params
packages/k8s/jest.config.js Switched to ts-jest preset, added ESM Babel transforms
packages/k8s/package.json Bumped @actions/*, @kubernetes/client-node, uuid, etc.
Comments suppressed due to low confidence (2)

packages/k8s/tsconfig.json:10

  • JSON does not allow trailing commas in arrays—remove the comma after the last include entry.
      "src/**/*",

packages/k8s/tests/test-setup.ts:55

  • [nitpick] These cleanup calls run sequentially and swallow errors; consider using Promise.all([...]) with individual .catch() calls to run them in parallel and reduce total cleanup time.
      .deleteNamespacedPersistentVolumeClaim({

@nikola-jokic nikola-jokic merged commit 589414e into main Jul 29, 2025
3 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/deps branch July 29, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants