Skip to content

Refactor theming to use CSS custom properties#130

Merged
jmthomas merged 2 commits intomasterfrom
styles
Jan 9, 2026
Merged

Refactor theming to use CSS custom properties#130
jmthomas merged 2 commits intomasterfrom
styles

Conversation

@jmthomas
Copy link
Collaborator

@jmthomas jmthomas commented Jan 8, 2026

Replace SASS variable-based theming with CSS custom properties for easier runtime customization. This allows users to override theme colors without needing a SASS build pipeline.

  • Add CSS custom properties for all theme colors with light defaults
  • Replace ace-diff-dark.scss with ace-diff-twilight.scss preset
  • Update build to compile twilight theme as separate CSS file
  • Add theming documentation to README
  • Add Cypress tests for theme CSS verification
  • Update TEST.md with improved testing documentation

Replace SASS variable-based theming with CSS custom properties for
easier runtime customization. This allows users to override theme
colors without needing a SASS build pipeline.

- Add CSS custom properties for all theme colors with light defaults
- Replace ace-diff-dark.scss with ace-diff-twilight.scss preset
- Update build to compile twilight theme as separate CSS file
- Add theming documentation to README
- Add Cypress tests for theme CSS verification
- Update TEST.md with improved testing documentation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@jmthomas jmthomas requested a review from ryan-pratt January 8, 2026 21:15
@jmthomas
Copy link
Collaborator Author

jmthomas commented Jan 8, 2026

Prior to this we were always importing the dark theme and it was overriding the base theme so it was effectively always dark.

@jmthomas jmthomas requested a review from EmilyRagan January 9, 2026 00:11
@jmthomas jmthomas merged commit 108629f into master Jan 9, 2026
2 checks passed
@jmthomas jmthomas deleted the styles branch January 9, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant