Fix endless loop on src/helpers/merge.js:23#121
Merged
jmthomas merged 1 commit intoace-diff:masterfrom Jul 9, 2025
bkmetzler:fix_endless_loop
Merged
Fix endless loop on src/helpers/merge.js:23#121jmthomas merged 1 commit intoace-diff:masterfrom bkmetzler:fix_endless_loop
jmthomas merged 1 commit intoace-diff:masterfrom
bkmetzler:fix_endless_loop
Conversation
When attempting to use AceDiff, merge keeps throwing the following
exception in the web browser console:
merge.js:18 Uncaught RangeError: Maximum call stack size exceeded
at eval (merge.js:18:1)
at Array.forEach (<anonymous>)
at merge (merge.js:18:1)
at eval (merge.js:23:1)
at Array.forEach (<anonymous>)
at merge (merge.js:18:1)
at eval (merge.js:23:1)
at Array.forEach (<anonymous>)
at merge (merge.js:18:1)
at eval (merge.js:23:1)
This shows the infinite loop. By adding a basic comparison, it removes
this loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to use AceDiff, merge keeps throwing the following exception in the web browser console:
This shows the infinite loop. By adding a basic comparison, it removes this loop.
Details:
Operating System: Ubuntu Linux 24.04.2 LTS
Web Browser: Google Chrome
Web Browser Version 138.0.7204.100 (Official Build) (64-bit)