fix destroy() to exec removeEventHandlers() even if the gutter is already gone#114
Merged
jmthomas merged 3 commits intoace-diff:masterfrom May 19, 2025
Merged
fix destroy() to exec removeEventHandlers() even if the gutter is already gone#114jmthomas merged 3 commits intoace-diff:masterfrom
jmthomas merged 3 commits intoace-diff:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since we are using ace-diff in a modal-panel it might happen, that the destroy() methods is trying to adjust the gutter even though it might not be present in the DOM. By adding a defensive mechanism we ensure that the removeEventListener() method is called for sure.