Fix removing resize event handler when multiple instances of AceDiff are created/disposed at the same time#113
Merged
jmthomas merged 1 commit intoace-diff:masterfrom May 19, 2025
Conversation
…are created/disposed at the same time
empinator
added a commit
to empinator/ace-diff
that referenced
this pull request
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple instances are created and exist at the same time, the module
removeEventHandlerswould only contain theonResizehandler for the last instance created, causing theremoveEventListenerindestroy()leaving behind the listeners from the earlier instances.This then triggers console errors
Cannot read property 'offsetHeight' of null, caused by the strayonResizehandlers being called with the Ace instance DOM element no longer existing.The fix simply keeps the
removeEventHandlerswith the AceEditor instance rather than on the shared module variable.Fixes #64